Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stub out new nyc event at Reaktor #125

Merged
merged 14 commits into from
Feb 16, 2024
Merged

stub out new nyc event at Reaktor #125

merged 14 commits into from
Feb 16, 2024

Conversation

edwardsharp
Copy link
Contributor

@edwardsharp edwardsharp commented Feb 14, 2024

initial details for nyc meetup at Reaktor office thursday, april 25, 2024 from 6-10pm.

hoping to drum up some proposals so will be adding more speaker details soon!

i don't have the env vars needed to run this successfully on my localhost machine; so i hope this looks fine.

edit: ooo, but there's a preview deployment! https://deploy-preview-125--queerjs.netlify.app/new-york/ 😎

  • probably need to do something about the RSVPs? maybe that's what the airtable stuff does. (i think not re-writing new-york.yaml solved this! 🥳 )
  • not sure if i formatted the date correctly? date: 04/25/2024 assumed month/day/year format. (looking at the preview build now, i think that's correct ✅)

@littledan
Copy link

Could you make a new parallel yaml file rather than modifying the existing one? See Berlin for an example of a city that has hosted multiple events.

@edwardsharp
Copy link
Contributor Author

Could you make a new parallel yaml file rather than modifying the existing one? See Berlin for an example of a city that has hosted multiple events.

o sure; that actually makes a lot more sense, thanks for the tip!

data/new-york-2024.yaml Outdated Show resolved Hide resolved
@edwardsharp
Copy link
Contributor Author

hmm, the CI jobs are failing now, and i don't know why? maybe the organizers: yaml section is invalid??

@SaraVieira
Copy link
Member

@edwardsharp @littledan Build fixed and now we have Github actions so if it fails everyone can see why

@littledan
Copy link

Huh, it doesn't seem to show us organizers on the page. Are we supposed to be mainOrganizer, or mc, to show up?
https://deploy-preview-125--queerjs.netlify.app/new-york-2024/

@edwardsharp
Copy link
Contributor Author

amazing and thank you @SaraVieira 🥳

one thing, is maybe (to double-check), did you mean to commit the GATSBY_AIRTABLE_KEY in .env.production?

@edwardsharp
Copy link
Contributor Author

Huh, it doesn't seem to show us organizers on the page. Are we supposed to be mainOrganizer, or mc, to show up?
https://deploy-preview-125--queerjs.netlify.app/new-york-2024/

@littledan i moved it back to speakers: 🤷

@SaraVieira
Copy link
Member

@edwardsharp @littledan Okay that was a a weird code choice I made there, fixed it. Sorry I didn't have much time to update the website so it was all super wonky

also yeah i put the env by choice, airtable now has role based API keys so this one is just a read

Copy link

@littledan littledan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@@ -70,9 +72,10 @@ const Main = ({ city, attendees }) => {
<Sponsors sponsors={sponsors} />
</Panel>
)}
{mainOrganizer && mainOrganizer.length > 0 ? (
<Panel heading={mainOrganizer.length > 1 ? 'Organizers' : 'Organizer'}>
<Organizers organizers={mainOrganizer} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will affect the rendering of some existing yaml files, but maybe in a good way, e.g.,

mainOrganizer:

@edwardsharp
Copy link
Contributor Author

@littledan and @SaraVieira i pushed one thing where the organizers href was linking to twitter.com/null so added a link to github || twitter (tho fwiw, twitter (either twitterLink or twitterHandle) was coming back as null)

anyhow, yeah, feel like this could merge??

@SaraVieira
Copy link
Member

Sounds good! Ship it!!

@edwardsharp
Copy link
Contributor Author

edwardsharp commented Feb 16, 2024

Sounds good! Ship it!!

okay! i've shipped it as far as i can! i don't have the permissions to merge this, so i need some help from someone else 🥺

@SaraVieira SaraVieira merged commit 369e113 into queerjs:master Feb 16, 2024
4 checks passed
@SaraVieira
Copy link
Member

Done!!

@edwardsharp edwardsharp deleted the e-add-nyc-meetup-april-2024 branch February 17, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants